Ask HN: Is it acceptable to put up large pull requests?

My coworker regularly puts up 1500+ line pull requests that are in a single diff. I find it nearly impossible to give good feedback to this many changes at one once – and to go through it thoroughly can take me well over an hour (so I usually am not thorough.)

Am I wrong to balk at this? Should I just consider it part of the job and suck it up, or do I have a legitimate grievance here?

I’ve worked at places that would straight up reject a PR if it was too big and demand it be broken out into smaller logical pieces – but we definitely do not have that culture here.

Comments URL: https://news.ycombinator.com/item?id=41949894

Points: 1

# Comments: 0